Skip to content

Conversation

@elmiko
Copy link
Contributor

@elmiko elmiko commented Jul 28, 2021

This change was created by running make new-repo and following the prompts.

This change was created by running `make new-repo` and following the
prompts.
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 28, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elmiko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2021
@elmiko
Copy link
Contributor Author

elmiko commented Jul 28, 2021

@Fedosin ptal, just want to make sure i did this correctly =)

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 28, 2021

@elmiko: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
ci/rehearse/openshift/cluster-api-provider-alibaba/main/unit e949c3a link /test pj-rehearse
ci/prow/pj-rehearse e949c3a link /test pj-rehearse

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@elmiko
Copy link
Contributor Author

elmiko commented Aug 9, 2021

/test app-ci-config-dry

Copy link
Contributor

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this sufficient to set up the merge requirements? IIRC there's some paritcular file that needs to be created to configure tide. Let's double check and include that if not already included

image_stream_tag:
name: release
namespace: openshift
tag: golang-1.15
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
tag: golang-1.15
tag: golang-1.16

- commandHelpLink: ""
repos:
- openshift/cluster-api-provider-alibaba
require_self_approval: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We tend to require self approval on our team's repos

Suggested change
require_self_approval: false
require_self_approval: true

@elmiko
Copy link
Contributor Author

elmiko commented Oct 11, 2021

Is this sufficient to set up the merge requirements? IIRC there's some paritcular file that needs to be created to configure tide. Let's double check and include that if not already included

did you mean a file here or in the target repo?

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 11, 2021

@elmiko: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 11, 2021
@JoelSpeed
Copy link
Contributor

did you mean a file here or in the target repo?

IIRC there's some special configuration that has to go into this repo 🤔 @Fedosin you did this recently, have we got tide set up correctly?

@elmiko
Copy link
Contributor Author

elmiko commented Oct 11, 2021

ack, i can review some of our other PRs

@elmiko
Copy link
Contributor Author

elmiko commented Oct 11, 2021

this is outdated by #22459

@elmiko elmiko closed this Oct 11, 2021
@elmiko elmiko deleted the add-cluster-api-provider-alibaba branch October 11, 2021 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants